impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5116: Removal of uses for the deprecated functions in gutil
Date Thu, 13 Jul 2017 21:30:38 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5116: Removal of uses for the deprecated functions in gutil
......................................................................


Patch Set 1:

(7 comments)

THank you for sending this patch! A few questions:

http://gerrit.cloudera.org:8080/#/c/7414/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Removal of uses for the deprecated functions in gutil
"Remove deprecated hash_* types in gutil"


PS1, Line 9: functions
class templates


PS1, Line 9: for
from


http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h
File be/src/gutil/hash/hash.h:

Line 222
I don't think gcc ships with a std::hash overload for uint128. Why doesn't removing this break
the build?


Line 278
http://en.cppreference.com/w/cpp/utility/hash :

"std::hash<const char*> produces a hash of the value of the pointer (the memory address)"


http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/strings/split.h
File be/src/gutil/strings/split.h:

Line 135
Has this fact about container-ism changed?


Line 132: // multimap, unordered_set and unordered_map, and
Fix early line break


-- 
To view, visit http://gerrit.cloudera.org:8080/7414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message