impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function
Date Thu, 13 Jul 2017 19:15:33 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5650: Make sum_init_zero a SUM function
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7404/3/be/src/exec/partitioned-aggregation-node.cc
File be/src/exec/partitioned-aggregation-node.cc:

Line 1590:     // 'slot_desc' is not nullable if the aggregate function is sum_init_zero().
Also add a comment stating that: In which case, the slot is initialized to be zero and null
bit is cleared.


Line 1592:       slot_desc->CodegenSetNullIndicator(
> Can you add a DCHECK to make sure it's not sum_init_zero()?
Alternately, DCHECK(slot_desc->is_nullable() || agg_fn->fn_name() == "sum_init_zero");


-- 
To view, visit http://gerrit.cloudera.org:8080/7404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca53e3ef6bad5283550100b33db55d674cff0b9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message