impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations
Date Thu, 13 Jul 2017 18:11:26 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5520: TopN node periodically reclaims old allocations
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/7400/1/be/src/exec/topn-node-ir.cc
File be/src/exec/topn-node-ir.cc:

Line 61: }
> Done
Looks like you missed the second part of this (I wasn't that clear). I don't think the call
to ReclaimTuplePool() needs to be cross-compiled to LLVM IR. It can be called after InsertBatch()
instead of from inside InsertBatch().


http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.cc
File be/src/exec/topn-node.cc:

PS3, Line 244: tuple_row_comparator_wrapper_
I think something like ComparatorWrapper(*tuple_row_less_than_) will work.


PS3, Line 259: NULL
It would be best to pass in the RuntimeState* - that enables better logging of the failure.


PS3, Line 271: NULL
Same here.


http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.h
File be/src/exec/topn-node.h:

Line 36: #define PUSH_HEAP(v, comp, elem) v.push_back(elem); \
It's probably best to just make it an inline function, it doesn't seem like it needs to be
a macro.


Line 100:   boost::scoped_ptr<ComparatorWrapper<TupleRowComparator>> tuple_row_comparator_wrapper_;
We don't need to store this additional state, since all the state is in tuple_row_less_than_
- we can just create a wrapper where needed.


PS3, Line 134: vector
Also mention that it's updated with push_heap()/pop_heap().


-- 
To view, visit http://gerrit.cloudera.org:8080/7400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I968f57f0ff2905bd581908bc5c5ee486b31e6aa8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message