impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5539: Kudu timestamp scans wrong with -use local tz for unix ts
Date Wed, 12 Jul 2017 01:07:15 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts
......................................................................


Patch Set 2:

@Dan, I still need to add some expr-tests for the exposed fn "unix_micros_to_utc_timestamp()",
but I wanted to get a bit more feedback before next week when you're out. I didn't go through
and rename things in TimestampFunctions yet. I also didn't bother renaming the static factory
fns in TimestampValue because I'm going to move the helper methods to a Util class later,
at which point I'll rename them to be consistent with the model I mentioned before.

-- 
To view, visit http://gerrit.cloudera.org:8080/7311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I423a810427353be76aa64442044133a9a22cdc9b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message