impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read
Date Wed, 12 Jul 2017 00:34:14 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read
......................................................................


IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read

Reading a uninitialized memory as a boolean is undefined behavior when
it isn't the bit pattern for true or false. Clang's undefined behavior
sanitizer caught is_cancelled_ being used before being initialized;
this patch also initializes the other booleans in DiskIoMgr::ScanRange
to prevent similar undefined behavior.

Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae
Reviewed-on: http://gerrit.cloudera.org:8080/7294
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/disk-io-mgr-scan-range.cc
M be/src/runtime/disk-io-mgr.h
2 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message