impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule
Date Tue, 11 Jul 2017 23:55:26 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5104: Fix Query Admission Rule
......................................................................


Patch Set 1:

(5 comments)

Looks pretty good, just some nits.

http://gerrit.cloudera.org:8080/#/c/7401/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Fix Query Admission Rule
Vague subject line, which is often the only thing shown (e.g. git log --oneline, etc.). Can
you make this:
"Admit queries with mem equal to proc mem_limit"


http://gerrit.cloudera.org:8080/#/c/7401/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

PS1, Line 323: PROC_MEM_TEST_LIMIT
move this constant to just above this method since it's only used here


PS1, Line 326: query
a query


PS1, Line 326: process
the process


PS1, Line 326: requested
the requested


-- 
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message