impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246
Date Tue, 11 Jul 2017 22:33:14 GMT
John Russell has posted comments on this change.

Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7397/1/impala-docs.html
File impala-docs.html:

PS1, Line 149: impala.pdf
> When I open the PDF (impala.pdf), there is no identification on the PDF tha
You all have convinced me. The fact of the version number not being on the title page of the
PDF is an oversight but might not be so simple to enable, so let's use the filename to reinforce
the applicable version for now.

I found that git can store symbolic links:

https://stackoverflow.com/questions/954560/how-does-git-handle-symbolic-links

so I would like to run an experiment later to see if we can make a stable link to the 'latest'
PDF irrespective of version. Will need to check if the symlink survives going from git to
the Apache web server.


-- 
To view, visit http://gerrit.cloudera.org:8080/7397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2209088d0120a7b1243113466b33159a4f8a25e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message