impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3381: Support AM/PM marker in date and time format strings
Date Tue, 11 Jul 2017 15:06:36 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-3381: Support AM/PM marker in date and time format strings
......................................................................


Patch Set 2:

> What did we decide here? Can we move this forward or should we
 > abandon the change?

Impala's implementation of pattern letters follows SimpleDateFormat but it also deviates from
SimpleDateFormat in some aspects, which causes some discrepancies. No decision has been made
about resolving these discrepancies. Since this is a low-priority issue, I'm abandoning it
for now.

-- 
To view, visit http://gerrit.cloudera.org:8080/6523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99794a3e152f1712c6c469bb266d23a81d19ca34
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message