impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Prevent leaking AWS credentials to the log.
Date Tue, 11 Jul 2017 00:17:37 GMT
Lars Volker has posted comments on this change.

Change subject: Prevent leaking AWS credentials to the log.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7391/2/functions.sh
File functions.sh:

Line 380:     if set +o | grep -q "set -o xtrace"; then
Should we parse "set -o" here instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message