impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Date Mon, 10 Jul 2017 03:46:48 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7175/3/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

PS3, Line 134:  or the <
> Since the link text is "INSERT Statement" it is not necessary to include it
Done


PS3, Line 158: <codeblock><![CDATA[
             : <property>
             :    <name>dfs.adls.oauth2.access.token.provider.type</name>
             :    <value>ClientCredential</value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.client.id</name>
             :    <value><varname>your_client_id</varname></value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.credential</name>
             :    <value><varname>your_client_secret</varname></value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.refresh.url</name>
             :    <value><varname>refresh_URL</varname></value>
             : </property>
             : ]]>
> Do you tell users where they should get "your_client_id," "your_client_secr
I'm relying to some extent on users to work out the precise details from the Microsoft and
Hadoop instructions I linked towards the top of this page.  In the downstream docs I may elaborate
in some areas and simplify in others by linking to or reusing info from the overall CDH +
ADLS pages, but that's not appropriate here.

BTW, I haven't actually succeeded in getting an ADLS connection working yet despite some back-and-forth
with the local experts.


PS3, Line 179: <p>
             :           Check
> We have 4 environment variables for the Impala minicluster:
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message