impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5629: avoid expensive list::size() call
Date Sun, 09 Jul 2017 21:31:43 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5629: avoid expensive list::size() call
......................................................................


Patch Set 2:

We need efficient pop_front(), which rules out std::vector.

std::deque isn't a drop-in replacement since the code depends on the read_page_ iterator remaining
valid when pages_.push_back() is called, which std::deque doesn't guarantee (I only learned
this when I tried it and the tests crashed). I think we could solve that by using an index
for read_page_ instead of an iterator, but I thought I'd start with the minimal fix.

-- 
To view, visit http://gerrit.cloudera.org:8080/7382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83fcf68dcc3ea729df167885f999ff32b861e66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message