impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Date Sun, 09 Jul 2017 20:11:55 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................


Patch Set 9:

> Hi,Jim.I pull this patch by download the url, rebase it to master
 > branch, then submit new code, but it doesn't resolve the conflict.
 > Would you please resolve the conflict please?
 > Thank you.

I notice you have been contributing several patches to Impala recently. As a member of the
PPMC, welcome, and I'm glad to have you contributing!

Resolving merge conflicts is a routine part of the patch submission process, but, as you have
noticed, that doesn't make it easy to learn. I am happy to help you learn. In my last response
on this patch, I said,

"It would also be good to record, this next time you try, exactly which steps you took so
you can copy-and-paste them here for diagnosis."

Can you please copy-and-paste the exact commands you entered into your terminal so I can help
you resolve this?

If that terminal is closed, can you please re-try your efforts, recording this time the exact
commands you entered into your terminal?

-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message