impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5625: write profile when query times out
Date Fri, 07 Jul 2017 19:30:34 GMT
Tim Wood has posted comments on this change.

Change subject: IMPALA-5625: write profile when query times out
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7376/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

Line 865:           LOG.debug("Query id is %s", report.query_id)
Should the comma be a % sign?


Line 871:                 report.profile = cursor.get_profile()
Do we want to set should_cancel here since time is exceeded?


-- 
To view, visit http://gerrit.cloudera.org:8080/7376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dbdf5fcf97d6c5681c9fc8fb9eb448bc459b3b0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message