impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Date Fri, 07 Jul 2017 19:13:15 GMT
Laurel Hale has posted comments on this change.

Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support
......................................................................


Patch Set 3:

(2 comments)

Couple of issues found

http://gerrit.cloudera.org:8080/#/c/7175/3/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

PS3, Line 134: statement
Since the link text is "INSERT Statement" it is not necessary to include it again--creates
a duplication of the word. Remove this "statement."


PS3, Line 158: <codeblock><![CDATA[
             : <property>
             :    <name>dfs.adls.oauth2.access.token.provider.type</name>
             :    <value>ClientCredential</value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.client.id</name>
             :    <value><varname>your_client_id</varname></value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.credential</name>
             :    <value><varname>your_client_secret</varname></value>
             : </property>
             : <property>
             :    <name>dfs.adls.oauth2.refresh.url</name>
             :    <value><varname>refresh_URL</varname></value>
             : </property>
             : ]]>
Do you tell users where they should get "your_client_id," "your_client_secret," and the "refresh_URL"?
These values come from values you set when you create your ADLS service principal and the
refresh URL comes from the "Endpoints" setting in the Azure portal (Azure Active Directory
> App registrations > Endpoints).


-- 
To view, visit http://gerrit.cloudera.org:8080/7175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message