impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem
Date Fri, 07 Jul 2017 01:10:41 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7371/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java
File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java:

Line 1034:           t == Type.STRING ? stringValGetValue : null,
One quick question about the code below:

https://github.com/apache/incubator-impala/blob/master/be/src/exec/analytic-eval-node.cc#L470

Is lag() converted to lead() in the planner somehow or does it also need fixing ?


-- 
To view, visit http://gerrit.cloudera.org:8080/7371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b69b4ccb9cac076abca19bed6f0b1dd11dfff3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message