impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5498: Support for partial sorts
Date Fri, 07 Jul 2017 00:24:27 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5498: Support for partial sorts

Patch Set 3:

File be/src/exec/

Line 104:       sorter_->Reset();
> To be clear - what you're saying is that Open() will want to allocate memor
I wouldn't expect incorrect results, but it could result in queries failing with OOM when
they shouldn't.
File be/src/runtime/

Line 1384:   int min_buffers_required = MIN_BUFFERS_PER_MERGE;
Need to update this calculation for partial sorts.
File be/src/runtime/sorter.h:

Line 96:   Sorter(const TupleRowComparator& compare_less_than,
Wasn't the plan to apply the partition sort memory limit to the sorter itself?
File common/thrift/PlanNodes.thrift:

PS3, Line 349:  highest/lowest
Should this be "first" since the order is specified elsewhere.

"Return the first N elements in sorted order"?
File fe/src/main/java/org/apache/impala/planner/

Line 58:   private final long PARTIAL_SORT_MEM_LIMIT = BackendConfig.INSTANCE.getReadSize()
* 100;
It might be clearer to specify this in bytes, then just make sure that its >= 2 * read_size.

Although we really don't expect people to change read_size.

Line 286:       resourceProfile_ = new ResourceProfile(
This looks good to me.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message