impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes
Date Fri, 07 Jul 2017 00:01:18 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7358/3/be/src/runtime/buffered-tuple-stream-v2.h
File be/src/runtime/buffered-tuple-stream-v2.h:

Line 284:   /// Called after AddRowCustomBegin(). See the AddRowCustomBegin() comment for
i suppose this doesn't/shouldn't be called if AddRowCustomBegin() returns nullptr and/or !status->ok()?


PS3, Line 540: AddRowCustomEndSlow
the name makes it sound like this is symmetric to AddRowCustomBeginSlow(), but it's not. 
Maybe AddLargeRowCustomEnd() or similar?


-- 
To view, visit http://gerrit.cloudera.org:8080/7358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibab0d774f66be632f17376a56abf302821cca047
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message