impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings
Date Thu, 06 Jul 2017 21:04:33 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5580: fix Java UDFs that return NULL strings
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7364/1/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

Line 330:   if (result.is_null) return StringVal::null();
Can't we make CopyFrom() return a String::null() instead of an empty string for a null input?
Not sure if that breaks anything else but seems more intuitive to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/7364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34d288aad66a2609484058c9a177c02200cb6a6e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message