impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLSö0A
Date Thu, 06 Jul 2017 19:20:11 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1
......................................................................


Patch Set 3:

(2 comments)

Looks good to me. If you fix the typo in the commit message and rebase then I can start the
merge.

http://gerrit.cloudera.org:8080/#/c/7219/3//COMMIT_MSG
Commit Message:

PS3, Line 7: DISABLE_UNFASE_SPILLS
UNSAFE


http://gerrit.cloudera.org:8080/#/c/7219/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:

Line 437:   @Test
> Done
I believe JUnit test methods can be declared to throw exceptions. JUnit definitely catches
anything thrown by tests and fails that individual test with an error.


-- 
To view, visit http://gerrit.cloudera.org:8080/7219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccae7fdeaf0ade0b8728a7d249981c8270e8c327
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message