impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL
Date Thu, 06 Jul 2017 15:55:57 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

LGTM.

http://gerrit.cloudera.org:8080/#/c/7187/6/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

PS6, Line 480: args = '--var=foo'
             :     result = run_impala_shell_cmd(args, expect_success=False)
             :     assert ("Error: Could not parse key-value \"foo\". It must follow the pattern
"
             :              "\"KEY=VALUE\".") in result.stderr
Could you just move this test into test_var_substitution(). No need for a separate one.


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message