impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Donghui Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL
Date Thu, 06 Jul 2017 03:48:08 GMT
Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL
......................................................................


Patch Set 5:

(4 comments)

I have modified the code according to your opinion and added the test case.

http://gerrit.cloudera.org:8080/#/c/7187/4//COMMIT_MSG
Commit Message:

PS4, Line 9: print_to_stderr
> Please fix as you did below.
Done


PS4, Line 10: d
> The usual commit message style is that prose lines do not begin with spaces
Done


http://gerrit.cloudera.org:8080/#/c/7187/4/shell/impala_shell.py
File shell/impala_shell.py:

PS4, Line 1252: 
> Don't think this is needed.
Done


Line 1253:                         'It must follow the pattern "KEY=VALUE".')
> Mind adding a quick test in test_var_replacement() to cover this?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message