impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Date Thu, 06 Jul 2017 03:18:36 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/7175/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

Line 154:       
> L154 has trailing white space. It's best to remove trailing white space fro
Absolutely. I've gotten spoiled by a pre-commit hook that auto-removes any trailing spaces.
Wow, looking at the hook I see that check & fixup has been commented out for some time
now! I see that a few more have gotten into other files but I'll fix those separately.


PS1, Line 156:         As an alternative, specify the credentials in environment variables
before starting the <cmdname>impalad</cmdname>
             :         daemon.
> Is it possible to list a mapping between core-site.xml settings above and e
Yes. Need to consult with Sailesh or I think there is some CDH doc for ADLS I can adapt.


Line 219:           <li>
> This is still empty. :)
Need to consult with Sailesh. I haven't had hands-on experience with ADLS yet the way I have
with S3.


PS1, Line 261:         You point
> Maybe just an imperative "Point" ?
Almost. I'll word it as "To X, do Y". (Although now the wording on the S3 page is slightly
different. Too much trouble to track down every instance in upstream and downstream docs to
reconcile them all.)


PS1, Line 279:         For example,
> Because the paragraph starting at L269 mentions a database with a LOCATION,
Done


PS1, Line 313: !??? ls adl://impala-demo/dir1/dir2/dir3 --recursive;
What's the ADLS command line syntax to do this? (I'm basing this on an S3 example with 'aws
s3' commands.


PS1, Line 329: !??? ls adl://impala-demo/dir1/dir2/dir3 --recursive;
Same question as on line 313.


-- 
To view, visit http://gerrit.cloudera.org:8080/7175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message