impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Donghui Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Date Thu, 06 Jul 2017 02:59:42 GMT
Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................


Patch Set 5:

(3 comments)

I have solved the suggestion you have mentioned.

http://gerrit.cloudera.org:8080/#/c/7179/4/shell/option_parser.py
File shell/option_parser.py:

PS4, Line 88: If the argument to -f is "-", then queries are read from stdin"
            :                          " and terminated with ctrl-d
> Try "If the argument to -f is "-", then queries are read from stdin and ter
Done


PS4, Line 163: starts with an alphabetic character and"
> "starts with an alphabetic character"
Done


PS4, Line 164: only alphanumeric characters.")
> "only alphanumeric characters."
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message