impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL
Date Wed, 05 Jul 2017 17:02:52 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL
......................................................................


Patch Set 4:

(2 comments)

> (2 comments)
 > 
 > I have modified the code according to your opinion.
 > I think your advice is fine, but how do i know who is familiar with
 > that file?

git log $FILENAME

http://gerrit.cloudera.org:8080/#/c/7187/4//COMMIT_MSG
Commit Message:

PS4, Line 9: Print_to_stderr
Please fix as you did below.


PS4, Line 10:  
The usual commit message style is that prose lines do not begin with spaces.


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message