impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.
Date Wed, 05 Jul 2017 16:53:09 GMT
David Knupp has posted comments on this change.

Change subject: Complete guide to important environment variables for build, test, and mini-cluster
operations.
......................................................................


Patch Set 1:

(2 comments)

Whether it's a .txt file in the code base, or a wiki entry, how can we make sure that this
doc stays in sync with impala-config.sh (and/or any other place where env vars get set)? We'd
have multiple sources of truth, wouldn't we?

http://gerrit.cloudera.org:8080/#/c/7350/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 440
Speaking confidently as the only team member with a fine arts education, I'm shocked that
I did not know this setting existed. :-)


http://gerrit.cloudera.org:8080/#/c/7350/1/docs/Developer-Guide/Build-Environment.txt
File docs/Developer-Guide/Build-Environment.txt:

Line 1: Environment Variables:
How many of these are set in impala-config.sh, and how many are set by other means?


-- 
To view, visit http://gerrit.cloudera.org:8080/7350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message