impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL
Date Mon, 03 Jul 2017 21:38:28 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL
......................................................................


Patch Set 2:

(2 comments)

Thank you for your patch.

You might get faster reviews in the future if you pick a person who has worked on the file
in question and add them as a reviewer here in Gerrit.

http://gerrit.cloudera.org:8080/#/c/7187/2//COMMIT_MSG
Commit Message:

PS2, Line 9:  
Please do not end lines in spaces.


PS2, Line 13: Print_to_stderr
Functions are usually written "print_to_stderr()" - preserving capitalization and adding parens.


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message