impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Date Mon, 03 Jul 2017 21:35:34 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................


Patch Set 3:

(4 comments)

Thank you for sending this patch. A few comments:

http://gerrit.cloudera.org:8080/#/c/7179/3/shell/option_parser.py
File shell/option_parser.py:

PS3, Line 88: may
"will"


PS3, Line 88: stdin
Add back comment about ctrl+d?


PS3, Line 162: character
What exactly do you mean by character - do you mean a-z and A-Z?


PS3, Line 163: contains
What contains characters and/or numbers - KEY? VALUE?


-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message