Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C388200CBD for ; Thu, 22 Jun 2017 00:42:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3B340160BD5; Wed, 21 Jun 2017 22:42:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7DC13160BF0 for ; Thu, 22 Jun 2017 00:42:06 +0200 (CEST) Received: (qmail 53853 invoked by uid 500); 21 Jun 2017 22:42:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53827 invoked by uid 99); 21 Jun 2017 22:42:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 22:42:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E83971AFBCA for ; Wed, 21 Jun 2017 22:42:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id CxhgbHGEouW6 for ; Wed, 21 Jun 2017 22:42:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 957ED5F3FF for ; Wed, 21 Jun 2017 22:42:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5LMg258007315; Wed, 21 Jun 2017 22:42:02 GMT Date: Wed, 21 Jun 2017 22:42:02 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5553=3A_Fix_expr-test_in_release_builds=0A?= X-Gerrit-Change-Id: Id1257da350cb6cb69886e93f6615cdadd17c187d X-Gerrit-ChangeURL: X-Gerrit-Commit: d2a873df0572eb27e588911c434b0c0d050fd002 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 21 Jun 2017 22:42:07 -0000 Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7255 Change subject: IMPALA-5553: Fix expr-test in release builds ...................................................................... IMPALA-5553: Fix expr-test in release builds expr-test fails in release build as it uses Literal::CreateLiteral() to create literal expressions. Literal::CreateLiteral() wraps ParseString() with DCHECK() so it becomes a no-op in release builds. This change fixes the issue by moving Literal::CreateLiteral() from literal.cc to expr-test.cc as it's only used by the test code. Also replaces DCHECK() wrapped around ParseString() with EXPECT_TRUE(). Verified the fix by building and running a release build of expr-test. Change-Id: Id1257da350cb6cb69886e93f6615cdadd17c187d --- M be/src/exprs/expr-test.cc M be/src/exprs/literal.cc M be/src/exprs/literal.h 3 files changed, 114 insertions(+), 102 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7255/1 -- To view, visit http://gerrit.cloudera.org:8080/7255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1257da350cb6cb69886e93f6615cdadd17c187d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho