Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4E808200CBC for ; Tue, 20 Jun 2017 20:13:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4D46A160BE1; Tue, 20 Jun 2017 18:13:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 944AF160BCC for ; Tue, 20 Jun 2017 20:13:53 +0200 (CEST) Received: (qmail 27917 invoked by uid 500); 20 Jun 2017 18:13:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 27905 invoked by uid 99); 20 Jun 2017 18:13:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 18:13:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3252D192062 for ; Tue, 20 Jun 2017 18:13:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5y8gzPFZqxA0 for ; Tue, 20 Jun 2017 18:13:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BEC295F6D3 for ; Tue, 20 Jun 2017 18:13:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5KIDnv3025246; Tue, 20 Jun 2017 18:13:49 GMT Date: Tue, 20 Jun 2017 18:13:49 +0000 From: "Joe McDonnell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5536=3A_Fix_TCLIService_thrift_compilation_on_Hive_2=0A?= X-Gerrit-Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4d1d91af58ca98f484a24f759b9e8f9152985729 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 20 Jun 2017 18:13:54 -0000 Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7231 Change subject: IMPALA-5536: Fix TCLIService thrift compilation on Hive 2 ...................................................................... IMPALA-5536: Fix TCLIService thrift compilation on Hive 2 This fixes some issues with Impala compilation on Hive 2: 1. It fixes TCLIService.thrift generation by changing common/thrift/CMakeLists.txt to create the directory before generating the file and adding a dependency to generate TCLIService.thrift before compiling the thrift files. 2. It modifies CatalogOpExecutor::applyAlterTable to use the MetastoreShim. With these changes, Impala builds successfully with Hive 2 in my environment and on automated builds. Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66 --- M common/thrift/CMakeLists.txt M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/7231/1 -- To view, visit http://gerrit.cloudera.org:8080/7231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell