Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0ABE6200C88 for ; Fri, 2 Jun 2017 19:52:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 08050160BD2; Fri, 2 Jun 2017 17:52:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4CC47160BBA for ; Fri, 2 Jun 2017 19:52:11 +0200 (CEST) Received: (qmail 91653 invoked by uid 500); 2 Jun 2017 17:52:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91638 invoked by uid 99); 2 Jun 2017 17:52:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2017 17:52:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D0F74182883 for ; Fri, 2 Jun 2017 17:52:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0Xc8KyKQU1oC for ; Fri, 2 Jun 2017 17:52:09 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D65835F242 for ; Fri, 2 Jun 2017 17:52:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v52Hq7Ia027381; Fri, 2 Jun 2017 17:52:08 GMT Date: Fri, 2 Jun 2017 17:52:07 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5381=3A_Adds_DEFAULT_JOIN_STRATEGY_query_option=2E=0A?= X-Gerrit-Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c X-Gerrit-ChangeURL: X-Gerrit-Commit: f08613063e279a60db5cadc4832b301bfd78280b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 02 Jun 2017 17:52:12 -0000 Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7059 Change subject: IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option. ...................................................................... IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option. Adds a new query option DEFAULT_JOIN_STRATEGY to control which join strategy is chosen when the join inputs have an unknown cardinality (e.g., missing stats) or when the expected costs of the different strategies are equal. Values for DEFAULT_JOIN_STRATEGY: [BROADCAST, SHUFFLE] Default: BROADCAST Note that this change effectively undoes IMPALA-5120. Testing: - Added new planner tests - Core/hdfs run passed Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c --- M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/default-join-strategy-broadcast.test A testdata/workloads/functional-planner/queries/PlannerTest/default-join-strategy-shuffle.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test 9 files changed, 237 insertions(+), 88 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/7059/1 -- To view, visit http://gerrit.cloudera.org:8080/7059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm