Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BD811200CC4 for ; Thu, 29 Jun 2017 06:58:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BC421160BFA; Thu, 29 Jun 2017 04:58:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DE62160BF7 for ; Thu, 29 Jun 2017 06:58:57 +0200 (CEST) Received: (qmail 57229 invoked by uid 500); 29 Jun 2017 04:58:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 57217 invoked by uid 99); 29 Jun 2017 04:58:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jun 2017 04:58:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 72D671812D2 for ; Thu, 29 Jun 2017 04:58:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dUfc45BsAC3x for ; Thu, 29 Jun 2017 04:58:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F071F5F613 for ; Thu, 29 Jun 2017 04:58:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5T4wrqh028000; Thu, 29 Jun 2017 04:58:53 GMT Message-Id: <201706290458.v5T4wrqh028000@ip-10-146-233-104.ec2.internal> Date: Thu, 29 Jun 2017 04:58:53 +0000 From: "sandeep akinapelli (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: sakinapelli@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5280=3A_Coalesce_chains_of_OR_conditions_to_an_IN_predicate=0A?= X-Gerrit-Change-Id: If02396b752c5497de9a92828c24c8062027dc2e2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2e8c9657d595e510901604758a50f5a9fd722f3f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 29 Jun 2017 04:58:58 -0000 sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate ...................................................................... Patch Set 9: (1 comment) changed the testcase to include OR clause with another column http://gerrit.cloudera.org:8080/#/c/7110/8/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test: Line 85: select * from functional_kudu.zipcode_incomes where id = '1' or id = '2' or zip = '3' > I believe that was the intention of this test was to show that OR predicate Done -- To view, visit http://gerrit.cloudera.org:8080/7110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If02396b752c5497de9a92828c24c8062027dc2e2 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: sandeep akinapelli Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: sandeep akinapelli Gerrit-HasComments: Yes