Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5D7A200CB5 for ; Wed, 28 Jun 2017 00:16:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B4477160BE9; Tue, 27 Jun 2017 22:16:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0591E160BDC for ; Wed, 28 Jun 2017 00:16:25 +0200 (CEST) Received: (qmail 70487 invoked by uid 500); 27 Jun 2017 22:16:25 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 70476 invoked by uid 99); 27 Jun 2017 22:16:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 22:16:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9D091C11E7 for ; Tue, 27 Jun 2017 22:16:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xSjXVqsSM-ar for ; Tue, 27 Jun 2017 22:16:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 188AE5F2AE for ; Tue, 27 Jun 2017 22:16:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5RMGMVw022265; Tue, 27 Jun 2017 22:16:22 GMT Message-Id: <201706272216.v5RMGMVw022265@ip-10-146-233-104.ec2.internal> Date: Tue, 27 Jun 2017 22:16:22 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Brown Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5588=3A_Reduce_the_frequency_of_fault_injection=0A?= X-Gerrit-Change-Id: I0ce4445e8552a22f23371bed1196caf7d0a3f312 X-Gerrit-ChangeURL: X-Gerrit-Commit: ca94fe74e4116d9308df95d28d2e6c5b6d62fdc8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 27 Jun 2017 22:16:26 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-5588: Reduce the frequency of fault injection ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7310/1/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: PS1, Line 51: FAULT_INJECTION_SEND_RPC_EXCEPTION(16); > Yes, just small enough numbers to make sure error handling paths get exerci Given the frequency of ExecQueryFInstances() is relatively lower, we should probably use a slightly higher injection frequency. -- To view, visit http://gerrit.cloudera.org:8080/7310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ce4445e8552a22f23371bed1196caf7d0a3f312 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes