Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9BC2F200CC5 for ; Tue, 27 Jun 2017 05:12:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8F799160BDE; Tue, 27 Jun 2017 03:12:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D5530160BDA for ; Tue, 27 Jun 2017 05:12:48 +0200 (CEST) Received: (qmail 68867 invoked by uid 500); 27 Jun 2017 03:12:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 68844 invoked by uid 99); 27 Jun 2017 03:12:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 03:12:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 457D8180992 for ; Tue, 27 Jun 2017 03:12:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dQF1jGRBpGSI for ; Tue, 27 Jun 2017 03:12:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 652555F3A1 for ; Tue, 27 Jun 2017 03:12:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5R3CiwS002386; Tue, 27 Jun 2017 03:12:44 GMT Message-Id: <201706270312.v5R3CiwS002386@ip-10-146-233-104.ec2.internal> Date: Tue, 27 Jun 2017 03:12:44 +0000 From: "Vincent Tran (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Matthew Jacobs Reply-To: vttran@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5316=3A_Adds_last_day=28=29_function=0A?= X-Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370 X-Gerrit-ChangeURL: X-Gerrit-Commit: d5b6cb903de24c95de9000c473a6ddfca8516412 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 27 Jun 2017 03:12:49 -0000 Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/6/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 279: void TestLastDayFunction() { > Good catch, I suspect the intention was to call this in the same place Test I'm fixing this. -- To view, visit http://gerrit.cloudera.org:8080/6991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Vincent Tran Gerrit-HasComments: Yes