Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A144200CC5 for ; Tue, 27 Jun 2017 01:26:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 58A24160BDE; Mon, 26 Jun 2017 23:26:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9EA53160BDA for ; Tue, 27 Jun 2017 01:26:28 +0200 (CEST) Received: (qmail 41477 invoked by uid 500); 26 Jun 2017 23:26:27 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 41170 invoked by uid 99); 26 Jun 2017 23:26:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2017 23:26:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C7BBC1A037A for ; Mon, 26 Jun 2017 23:26:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aEEv9Xu6KL1x for ; Mon, 26 Jun 2017 23:26:26 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 539F55F5B9 for ; Mon, 26 Jun 2017 23:26:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5QNQNAj023875; Mon, 26 Jun 2017 23:26:24 GMT Message-Id: <201706262326.v5QNQNAj023875@ip-10-146-233-104.ec2.internal> Date: Mon, 26 Jun 2017 23:26:23 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5431=3A_Remove_redundant_path_exists_checks_during_table_load=0A?= X-Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281 X-Gerrit-ChangeURL: X-Gerrit-Commit: 647276d3b218789093d5347b2eb5f486821c01a8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 26 Jun 2017 23:26:29 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists checks during table load ...................................................................... Patch Set 7: Code-Review+2 (3 comments) Carrying +2. http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS5, Line 302: RemoteIterator fileStatusIter = > nit: move it below L305. If we're going to return there is no need to get a Done PS5, Line 727: DataFile(fileStatus)) continue; > newFileDescs? Done. Rewrote a little. http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: Line 498: return fs.listStatus(p); > I am thinking maybe add a warn in the log that the path doesn't exist. Done -- To view, visit http://gerrit.cloudera.org:8080/7095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes