Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B97B8200CB0 for ; Fri, 23 Jun 2017 21:05:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE87F160BE5; Fri, 23 Jun 2017 19:05:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F3851160BE2 for ; Fri, 23 Jun 2017 21:05:46 +0200 (CEST) Received: (qmail 41289 invoked by uid 500); 23 Jun 2017 19:05:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 41271 invoked by uid 99); 23 Jun 2017 19:05:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jun 2017 19:05:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 670E8C1471 for ; Fri, 23 Jun 2017 19:05:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PJIgS5b3wnsj for ; Fri, 23 Jun 2017 19:05:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7D5BA5F5B3 for ; Fri, 23 Jun 2017 19:05:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5NJ5elr020886; Fri, 23 Jun 2017 19:05:40 GMT Message-Id: <201706231905.v5NJ5elr020886@ip-10-146-233-104.ec2.internal> Date: Fri, 23 Jun 2017 19:05:40 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Juan Yu , Michael Ho Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5483=3A_Automatically_disable_codegen_for_small_queries=0A?= X-Gerrit-Change-Id: I273bcee58641f5b97de52c0b2caab043c914b32e X-Gerrit-ChangeURL: X-Gerrit-Commit: ed33ce7d78a6ac6e87588427ce4c3d0b6a4ea2bf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 23 Jun 2017 19:05:47 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7153/3/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: Line 151: > Happy to do this but will defer the work until we have a clear decision abo I'm on board with merging this change with a 50K default. http://gerrit.cloudera.org:8080/#/c/7153/3/fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java File fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java: Line 60: maxRowsProcessed_ = Math.max(maxRowsProcessed_, numRows); > In that case the scan returns every row it scans and hits the limit after p I'm thinking about the case: (missingStats && !scan.hasLimit() && !scan.getConjuncts().isEmpty()) That should be invalid imo, but today it is valid. http://gerrit.cloudera.org:8080/#/c/7153/3/testdata/workloads/functional-query/queries/QueryTest/codegen.test File testdata/workloads/functional-query/queries/QueryTest/codegen.test: Line 2: ---- QUERY > To confirm that it's actually plumbed all the way through to the backend. Don't we have other tests that confirm the codegen_hint is honored? Validating plan choices with EE tests and inspecting the profile seems odd to me. http://gerrit.cloudera.org:8080/#/c/7153/3/tests/common/test_dimensions.py File tests/common/test_dimensions.py: Line 139: disable_codegen_rows_threshold_options=[5000], > The reasoning below doesn't apply since disable_codegen is always on here. Works for me. I think we should generally reconsider the use of this function in various places, e.g. we use it for our TPCH/DS functional tests. -- To view, visit http://gerrit.cloudera.org:8080/7153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I273bcee58641f5b97de52c0b2caab043c914b32e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes