Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 82909200CAF for ; Thu, 22 Jun 2017 23:52:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 81773160BE7; Thu, 22 Jun 2017 21:52:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC2EE160BD3 for ; Thu, 22 Jun 2017 23:52:30 +0200 (CEST) Received: (qmail 41854 invoked by uid 500); 22 Jun 2017 21:52:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 41841 invoked by uid 99); 22 Jun 2017 21:52:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 21:52:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 28A6ECF3B3 for ; Thu, 22 Jun 2017 21:52:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id aX6zoWB35Pqj for ; Thu, 22 Jun 2017 21:52:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C1EAF5F523 for ; Thu, 22 Jun 2017 21:52:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5MLqKj7000990; Thu, 22 Jun 2017 21:52:20 GMT Message-Id: <201706222152.v5MLqKj7000990@ip-10-146-233-104.ec2.internal> Date: Thu, 22 Jun 2017 21:52:20 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_DRAFT_-_IMPALA-5498=3A_Support_for_partial_sorts=0A?= X-Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 X-Gerrit-ChangeURL: X-Gerrit-Commit: feeb8b4040975fa9b6deee736955486fe7d33e35 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 22 Jun 2017 21:52:31 -0000 Thomas Tauber-Marshall has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts ...................................................................... Patch Set 1: (2 comments) I haven't looked much at the Planner changes needed, eg. in SortNode.computeResourceProfile, but this patch gives a good idea of the interface changes needed. http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.cc File be/src/exec/partial-sort-node.cc: Line 41: Status PartialSortNode::Init(const TPlanNode& tnode, RuntimeState* state) { There's a lot of boiler plate here and in Prepare, Open, and Codegen that could be shared with SortNode. http://gerrit.cloudera.org:8080/#/c/7267/1/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: Line 65: private final boolean useTopN_; This will be replaced with TSortType.TOPN -- To view, visit http://gerrit.cloudera.org:8080/7267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes