Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9DC2200CAF for ; Thu, 22 Jun 2017 21:13:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B879A160BD3; Thu, 22 Jun 2017 19:13:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07E0F160BE7 for ; Thu, 22 Jun 2017 21:13:24 +0200 (CEST) Received: (qmail 75263 invoked by uid 500); 22 Jun 2017 19:13:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75247 invoked by uid 99); 22 Jun 2017 19:13:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 19:13:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7CA68C0C76 for ; Thu, 22 Jun 2017 19:13:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hycQZszEkPQJ for ; Thu, 22 Jun 2017 19:13:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B8FDF5FD91 for ; Thu, 22 Jun 2017 19:13:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5MJDMWF027617; Thu, 22 Jun 2017 19:13:22 GMT Message-Id: <201706221913.v5MJDMWF027617@ip-10-146-233-104.ec2.internal> Date: Thu, 22 Jun 2017 19:13:22 +0000 From: "Lars Volker (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5562=3A_Only_recomputeMemLayout=28=29_if_tuple_has_a_layout=2E=0A?= X-Gerrit-Change-Id: I08548c6bfa7dbf4655e55636605bebb89d2a2239 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9e78a70df29dbd9017872e18bad89a731881785f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 22 Jun 2017 19:13:25 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. ...................................................................... Patch Set 1: (1 comment) Thank you for fixing this so quickly! http://gerrit.cloudera.org:8080/#/c/7264/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 245: collSlotRef.getDesc().getParent().recomputeMemLayout(); Have you considered returning early instead of the Precondition in recomputeMemLayout()? -- To view, visit http://gerrit.cloudera.org:8080/7264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08548c6bfa7dbf4655e55636605bebb89d2a2239 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes