Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 130E9200CAE for ; Wed, 21 Jun 2017 23:11:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 12040160BF3; Wed, 21 Jun 2017 21:11:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 532F1160BD0 for ; Wed, 21 Jun 2017 23:11:04 +0200 (CEST) Received: (qmail 30799 invoked by uid 500); 21 Jun 2017 21:11:02 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 30788 invoked by uid 99); 21 Jun 2017 21:11:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 21:11:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 07A381A03A9 for ; Wed, 21 Jun 2017 21:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KZGO6vBtSNND for ; Wed, 21 Jun 2017 21:11:01 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A7A315F3FF for ; Wed, 21 Jun 2017 21:11:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5LLAw8B004092; Wed, 21 Jun 2017 21:10:58 GMT Message-Id: <201706212110.v5LLAw8B004092@ip-10-146-233-104.ec2.internal> Date: Wed, 21 Jun 2017 21:10:58 +0000 From: "Bikramjeet Vig (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Jim Apple , Dan Hecht , Matthew Jacobs Reply-To: bikramjeet.vig@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3504=3A_UDF_for_current_timestamp_in_UTC=0A?= X-Gerrit-Change-Id: I969fc805922f2bb9c8101e84f85ff2cc3b1b6729 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8da012d20c728a4bf4f92f376369613279045418 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 21 Jun 2017 21:11:05 -0000 Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7203/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: PS1, Line 371: a > as -> at I did a second look at this while looking at Dan's latest comment. I think it should remain as "set as the query submission time" since this means that it represents the query submission time. This would also remove the need to specify that it represents the same point in time as now_string -- To view, visit http://gerrit.cloudera.org:8080/7203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I969fc805922f2bb9c8101e84f85ff2cc3b1b6729 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes