Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201706210155.v5L1tjfh017092@ip-10-146-233-104.ec2.internal>
Date: Wed, 21 Jun 2017 01:55:45 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Henry Robinson <henry@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Sailesh Mukil <sailesh@cloudera.com>
Reply-To: kwho@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5537=3A_Retry_RPC_on_somes_exceptions_with_SSL_connection=0A?=
In-Reply-To: <gerrit.1497941934000.I8243d4cac93c453e9396b0e24f41e147c8637b8c@gerrit.cloudera.org>
References: <gerrit.1497941934000.I8243d4cac93c453e9396b0e24f41e147c8637b8c@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 21 Jun 2017 01:55:50 -0000

Michael Ho has posted comments on this change.

Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7229/5/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

PS5, Line 198: This is not very robust as it's
             : // possible that the receiver of the RPC call may have received all the RPC payload
             : // but the ACK to the sender may have been dropped somehow. In which case, it's
             : // not safe to retry the RPC if it's not idempotent.
> maybe reword this to say the caller should first check if the send was comp
Done


PS5, Line 202: end-to-end tracking of RPC calls to detect duplicated calls in the receiver side
> what does that mean? is it still applicable?
Removed.


http://gerrit.cloudera.org:8080/#/c/7229/5/be/src/runtime/client-cache.h
File be/src/runtime/client-cache.h:

Line 330:     client_is_unrecoverable_ = false;
> i guess this restores the behavior before the patch that introduced this Re
Yes. It was missing in the last patch. It resulted in sub-optimal behavior as good connection may be closed.


-- 
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes