Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4096E200CAC for ; Mon, 19 Jun 2017 22:36:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3F75F160BE1; Mon, 19 Jun 2017 20:36:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 86A32160BCD for ; Mon, 19 Jun 2017 22:36:55 +0200 (CEST) Received: (qmail 22153 invoked by uid 500); 19 Jun 2017 20:36:54 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 22135 invoked by uid 99); 19 Jun 2017 20:36:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jun 2017 20:36:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 779A3180A5A for ; Mon, 19 Jun 2017 20:36:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GYhuaCKUjbG2 for ; Mon, 19 Jun 2017 20:36:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 751295F6C6 for ; Mon, 19 Jun 2017 20:36:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5JKanWo009931; Mon, 19 Jun 2017 20:36:49 GMT Message-Id: <201706192036.v5JKanWo009931@ip-10-146-233-104.ec2.internal> Date: Mon, 19 Jun 2017 20:36:49 +0000 From: "Tim Armstrong (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Taras Bobrovytsky , Jim Apple , Dimitris Tsirogiannis Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3643/IMPALA-5344=3A_Fix_FE_tests_on_Java_8=0A?= X-Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 X-Gerrit-ChangeURL: X-Gerrit-Commit: ea86dfe6468bd53d2c60e585b6f0a99045bca951 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 19 Jun 2017 20:36:56 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ...................................................................... Patch Set 6: (12 comments) Looks good. Just have minor comments then I'm ready to +1. I think Alex or Dimitris should still have a pass over and confirm it makes sense ot them. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: PS6, Line 1485: HashMap LinkedHashMap? PS6, Line 1528: Map LinkedHashMap? PS6, Line 1695: LinkedHashMap? PS6, Line 1908: HashMap LinkedHashMap? http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: PS6, Line 444: Map LinkedHashMap? I don't feel as strongly about this one since it doesn't cross module boundaries. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 179: // LinkeHashSet where applicable to preserve the iteration order and make the class typo http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: PS6, Line 171: getSources getOrderedSources()? PS6, Line 176: getTargets Maybe getOrderedTargets()? PS6, Line 194: Map LinkedHashMap? Line 342: for (String target: Sets.newTreeSet(targets)) { It might be more efficient to use Guava's ImmutableSortedSet here and above. It gives you back a Set<> backed by a sorted array. I don't feel that strongly but it seems like it would be easy enough. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: PS6, Line 187: HashMap LinkedHashMap? PS6, Line 211: HashMap LinkedHashMap? -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes