Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32C31200CA8 for ; Thu, 15 Jun 2017 23:46:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 31535160BDF; Thu, 15 Jun 2017 21:46:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7766E160BC9 for ; Thu, 15 Jun 2017 23:45:59 +0200 (CEST) Received: (qmail 10347 invoked by uid 500); 15 Jun 2017 21:45:58 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 10336 invoked by uid 99); 15 Jun 2017 21:45:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 21:45:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 10193C0F96 for ; Thu, 15 Jun 2017 21:45:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id c2QCmqavj_SC for ; Thu, 15 Jun 2017 21:45:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4BC965F3BD for ; Thu, 15 Jun 2017 21:45:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5FLjuMI005792; Thu, 15 Jun 2017 21:45:56 GMT Message-Id: <201706152145.v5FLjuMI005792@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Jun 2017 21:45:56 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , Matthew Jacobs , Tim Armstrong Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BKUTIL=5D_Add_kudu_util_library_to_the_build=2E=0A?= X-Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7ddfb4b8137f031ff6bc4a2fba51eacadbc066e1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 15 Jun 2017 21:46:00 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc File be/src/kudu/util/minidump.cc: PS13, Line 96: namespace kudu { > Just wondering if things will break if we remove this file or simply delete We could just remove it from CMakeLists.txt (we already do that for another source file). That would ensure the code was never used, but would simplify refreshing the util source directory. What do you think? Eventually, I would like to both a) consider unifying our code and theirs for common utilities like this and b) selectively disable more files to reduce compilation time / binary size. -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes