Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 15DC7200CA8 for ; Thu, 15 Jun 2017 23:40:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 146BE160BDF; Thu, 15 Jun 2017 21:40:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5B150160BC9 for ; Thu, 15 Jun 2017 23:40:25 +0200 (CEST) Received: (qmail 1958 invoked by uid 500); 15 Jun 2017 21:40:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 1944 invoked by uid 99); 15 Jun 2017 21:40:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 21:40:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E96E0C69FF for ; Thu, 15 Jun 2017 21:40:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ivzQvs7etMS9 for ; Thu, 15 Jun 2017 21:40:20 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7497C5F27B for ; Thu, 15 Jun 2017 21:40:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5FLeH42005577; Thu, 15 Jun 2017 21:40:18 GMT Message-Id: <201706152140.v5FLeH42005577@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Jun 2017 21:40:17 +0000 From: "Michael Ho (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Tim Armstrong Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BKUTIL=5D_Add_kudu_util_library_to_the_build=2E=0A?= X-Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7ddfb4b8137f031ff6bc4a2fba51eacadbc066e1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 15 Jun 2017 21:40:26 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc File be/src/kudu/util/minidump.cc: PS13, Line 96: namespace kudu { > I believe this is dead code, as the MinidumpExceptionHandler is not instant Just wondering if things will break if we remove this file or simply delete most of its content ? I suppose the problem is that if we cherry-pick from Kudu, we may have to resolve conflicts ? -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes