Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 03E2B200CB6 for ; Thu, 15 Jun 2017 06:24:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 026FF160BE8; Thu, 15 Jun 2017 04:24:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4862A160BDB for ; Thu, 15 Jun 2017 06:24:02 +0200 (CEST) Received: (qmail 37125 invoked by uid 500); 15 Jun 2017 04:24:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37113 invoked by uid 99); 15 Jun 2017 04:24:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 04:24:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7A4DC1A0216 for ; Thu, 15 Jun 2017 04:24:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DUlNc99JeQq8 for ; Thu, 15 Jun 2017 04:23:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 739755F6C4 for ; Thu, 15 Jun 2017 04:23:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5F4NwbS024862; Thu, 15 Jun 2017 04:23:58 GMT Message-Id: <201706150423.v5F4NwbS024862@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Jun 2017 04:23:58 +0000 From: "Alex Behm (Code Review)" To: Vincent Tran , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4418=3A_Extra_blank_lines_in_query_result=0A?= X-Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839 X-Gerrit-ChangeURL: X-Gerrit-Commit: 64ca1fdf529e58c8ac1d00e3d4e99884faace648 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 15 Jun 2017 04:24:03 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4418: Extra blank lines in query result ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG Commit Message: Line 11: that returns 0 row. This change avoids printing blank lines when the Impala shell fetches 0 rows from a statement. http://gerrit.cloudera.org:8080/#/c/7055/3/shell/impala_shell.py File shell/impala_shell.py: Line 922: # IMPALA-4418: Breaking out of the loop to prevent an empty newline printing Break out of the loop to prevent printing an unnecessary empty line. (the rest is clear from the code context) http://gerrit.cloudera.org:8080/#/c/7055/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: Line 293: # IMPALA-4418 We use this format # IMPALA-4418: DROP AND USE ... # ... # ... Line 294: # DROP and USE are exception cases that client does not fetch. DROP and USE are generally exceptional statements where the client does not fetch. However, when preceded by a comment, the Impala shell treats them like any other statement and will try to fetch - receiving 0 rows. For statements returning 0 rows we do not want an empty line in stdout. Line 296: # CREATE [DATABASE|TABLE] should trigger a 0 row fetch Remove this part about CREATE in favor of the more general formulation above. Maybe add another test that does not require create, e.g.: select * from functional.alltypes limit 0 -- To view, visit http://gerrit.cloudera.org:8080/7055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Vincent Tran Gerrit-HasComments: Yes