Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201706141641.v5EGfF7w010517@ip-10-146-233-104.ec2.internal>
Date: Wed, 14 Jun 2017 16:41:15 +0000
From: "Joe McDonnell (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Marcel Kornacker <marcel@cloudera.com>
Reply-To: joemcdonnell@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1575=3A_Yield_admission_control_resources_at_query_end=0A?=
In-Reply-To: <gerrit.1496681752000.Ia5003d017b3142a160bacf7e3569ff26026b1700@gerrit.cloudera.org>
References: <gerrit.1496681752000.Ia5003d017b3142a160bacf7e3569ff26026b1700@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 14 Jun 2017 16:41:22 -0000

Joe McDonnell has posted comments on this change.

Change subject: IMPALA-1575: Yield admission control resources at query end
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/7079/1//COMMIT_MSG
Commit Message:

PS1, Line 12: query is finished
> query has transitioned to a state in which it will no longer return any mor
Done


PS1, Line 17: and
> an error
Done


PS1, Line 18: ended
> cancelled
Done


Line 19: 3. The query reaches eos (or the DML completes)
> Also: The query is cancelled by a client but not closed. (E.g. call HS2::Ca
Done


PS1, Line 22: complete
> avoid this word, e.g. use the wording I suggested above
Done


Line 24: 
> call out the limitations, i.e. this doesn't mean all backends have complete
Done


Line 25: Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700
> comment on testing? I assume we still need to do the cluster testing.
Added a test and a description of the changes to the test.


http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

Line 81: /// ImpalaServer::CancelInternal()/ClientRequestState::Cancel().)
> augment comment
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes