Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6D6F0200CAD for ; Wed, 14 Jun 2017 06:28:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6C1B7160BE9; Wed, 14 Jun 2017 04:28:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B1E79160BDC for ; Wed, 14 Jun 2017 06:28:43 +0200 (CEST) Received: (qmail 80721 invoked by uid 500); 14 Jun 2017 04:28:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 80710 invoked by uid 99); 14 Jun 2017 04:28:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Jun 2017 04:28:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4231DC05B0 for ; Wed, 14 Jun 2017 04:28:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id poCa6z3rwpgd for ; Wed, 14 Jun 2017 04:28:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 940EF5F27B for ; Wed, 14 Jun 2017 04:28:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5E4ScAJ006502; Wed, 14 Jun 2017 04:28:38 GMT Message-Id: <201706140428.v5E4ScAJ006502@ip-10-146-233-104.ec2.internal> Date: Wed, 14 Jun 2017 04:28:38 +0000 From: "Bharath Vissapragada (Code Review)" To: Donghui Xu , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5492=3A_Fix_incorrect_newline_character_in_the_LDAP_message=0A?= X-Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4ad2d07dd7e9c657e7e42d0b4767d131d7367eea In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 14 Jun 2017 04:28:44 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message ...................................................................... Patch Set 6: Code-Review+2 Thanks for fixing the nits. I'll run the pre commit job -- To view, visit http://gerrit.cloudera.org:8080/7166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: No