Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AB04200CA6 for ; Tue, 13 Jun 2017 23:59:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 99443160BDC; Tue, 13 Jun 2017 21:59:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1489160BC5 for ; Tue, 13 Jun 2017 23:58:59 +0200 (CEST) Received: (qmail 26376 invoked by uid 500); 13 Jun 2017 21:58:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 26359 invoked by uid 99); 13 Jun 2017 21:58:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jun 2017 21:58:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 810F8CF644 for ; Tue, 13 Jun 2017 21:58:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id evPOcDitT0Jj for ; Tue, 13 Jun 2017 21:58:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C82545FAF3 for ; Tue, 13 Jun 2017 21:58:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5DLwvnW029796; Tue, 13 Jun 2017 21:58:57 GMT Message-Id: <201706132158.v5DLwvnW029796@ip-10-146-233-104.ec2.internal> Date: Tue, 13 Jun 2017 21:58:57 +0000 From: "Michael Brown (Code Review)" To: John Russell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Laurel Hale Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5333=3A_=5BDOCS=5D_Document_Impala_ADLS_support=0A?= X-Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14 X-Gerrit-ChangeURL: X-Gerrit-Commit: 48bd9f1bb700b04e57dc98f7be470cc14d96a3da In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 13 Jun 2017 21:59:00 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support ...................................................................... Patch Set 1: (3 comments) I've read through roughly half of impala_adls.xml and noticed a few things. http://gerrit.cloudera.org:8080/#/c/7175/1/docs/topics/impala_adls.xml File docs/topics/impala_adls.xml: Line 154: L154 has trailing white space. It's best to remove trailing white space from text that is under revision control, whether it be prose, code, or markup. PS1, Line 156: As an alternative, specify the credentials in environment variables before starting the impalad : daemon. Is it possible to list a mapping between core-site.xml settings above and environment variable names? Line 219:
  • This is still empty. :) -- To view, visit http://gerrit.cloudera.org:8080/7175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes