Return-Path: <reviews-return-15125-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id A2791200C92
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 12 Jun 2017 22:31:12 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id A1309160BDE; Mon, 12 Jun 2017 20:31:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E8535160BCF
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 12 Jun 2017 22:31:11 +0200 (CEST)
Received: (qmail 14779 invoked by uid 500); 12 Jun 2017 20:31:11 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 14767 invoked by uid 99); 12 Jun 2017 20:31:10 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jun 2017 20:31:10 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8AC08C0118
	for <reviews@impala.apache.org>; Mon, 12 Jun 2017 20:31:10 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level: 
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id OlP9czJht71W for <reviews@impala.apache.org>;
	Mon, 12 Jun 2017 20:31:09 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 48BCD5F6CD
	for <reviews@impala.incubator.apache.org>; Mon, 12 Jun 2017 20:31:09 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5CKV4ln021839;
	Mon, 12 Jun 2017 20:31:04 GMT
Message-Id: <201706122031.v5CKV4ln021839@ip-10-146-233-104.ec2.internal>
Date: Mon, 12 Jun 2017 20:31:04 +0000
From: "Impala Public Jenkins (Code Review)" <gerrit@cloudera.org>
To: yu feng <hzfengyu@corp.netease.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
X-Gerrit-MessageType: merged
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5016=3A_Simplify_COALESCE=28=29_in_SimplifyConditionalsRule=2E=0A?=
X-Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/7015>
X-Gerrit-Commit: 61696f3ba81ba27d830bf262c6e56b0712f19e53
In-Reply-To: <gerrit.1496160744000.I0325a9e437261b15313bbdf2f22d83376a84b575@gerrit.cloudera.org>
References: <gerrit.1496160744000.I0325a9e437261b15313bbdf2f22d83376a84b575@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Mon, 12 Jun 2017 20:31:12 -0000

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
......................................................................


IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.

Simplify COALESCE by skipping leading nulls and applying the following
transformations:
COALESCE(null, a, b) -> COALESCE(a, b);
COALESCE(<literal>, a, b) -> <literal>, when literal is not NullLiteral;
COALESCE(<partition-slotref>, a, b) -> <partition-slotref>,
when the partition column does not contain NULL.

Testing:
added unit tests in ExprRewriteRulesTest

Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
Reviewed-on: http://gerrit.cloudera.org:8080/7015
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
2 files changed, 126 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: yu feng <hzfengyu@corp.netease.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: yu feng <hzfengyu@corp.netease.com>