Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E6C24200C91 for ; Sun, 11 Jun 2017 19:11:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E542B160BD7; Sun, 11 Jun 2017 17:11:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36F3C160B9C for ; Sun, 11 Jun 2017 19:11:37 +0200 (CEST) Received: (qmail 49072 invoked by uid 500); 11 Jun 2017 17:11:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 49061 invoked by uid 99); 11 Jun 2017 17:11:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Jun 2017 17:11:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A16A8180688 for ; Sun, 11 Jun 2017 17:11:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Cq4CP30leU4X for ; Sun, 11 Jun 2017 17:11:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C35CF5FCA1 for ; Sun, 11 Jun 2017 17:11:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5BHBYU0004132; Sun, 11 Jun 2017 17:11:34 GMT Message-Id: <201706111711.v5BHBYU0004132@ip-10-146-233-104.ec2.internal> Date: Sun, 11 Jun 2017 17:11:33 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5031=3A_Don=27t_dereference_uninitialized_memory_as_a_bool=2E=0A?= X-Gerrit-Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0afc97d61cb0f530013506e751d6f8f076778a24 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sun, 11 Jun 2017 17:11:38 -0000 Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool. ...................................................................... IMPALA-5031: Don't dereference uninitialized memory as a bool. Every bool takes up a byte of memory, but not every byte of memory is a valid bool. Dereferencing that memory, even if only to write to, it is undefined behavior. I tested exhaustive UBSAN and DEBUG. In UBSAN, the error is no longer present; in both UBSAN and DEBUG, all tests pass Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224 --- M be/src/runtime/raw-value.cc 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/7148/2 -- To view, visit http://gerrit.cloudera.org:8080/7148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple