Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 11163200CB0 for ; Fri, 9 Jun 2017 08:19:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0FB11160BE5; Fri, 9 Jun 2017 06:19:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56734160BD5 for ; Fri, 9 Jun 2017 08:19:27 +0200 (CEST) Received: (qmail 91229 invoked by uid 500); 9 Jun 2017 06:19:26 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91217 invoked by uid 99); 9 Jun 2017 06:19:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 06:19:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 813A3C0550 for ; Fri, 9 Jun 2017 06:19:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3V0GMaW1tpZb for ; Fri, 9 Jun 2017 06:19:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 563815F253 for ; Fri, 9 Jun 2017 06:19:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v596JLHk007323; Fri, 9 Jun 2017 06:19:21 GMT Message-Id: <201706090619.v596JLHk007323@ip-10-146-233-104.ec2.internal> Date: Fri, 9 Jun 2017 06:19:20 +0000 From: "yu feng (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: hzfengyu@corp.netease.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5016=3A_Try_to_rewrite_coalesce=28=29_function_in_SimplifyConditionalsRule=2E=0A?= X-Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575 X-Gerrit-ChangeURL: X-Gerrit-Commit: efd7905f9719024b70aec64439e302040fc5d2d2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 09 Jun 2017 06:19:28 -0000 yu feng has uploaded a new patch set (#4). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. ...................................................................... IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewrite coalesce() function with head-most nulls, constant values and HDFS table partition metadatas. which will make sence in partiton purning Testing: add some unit tests for SimplifyConditionalsRule with coalesce() function. run all test cases in SimplifyConditionalsRule and all passed. Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575 --- M fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java 2 files changed, 122 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7015/4 -- To view, visit http://gerrit.cloudera.org:8080/7015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: yu feng Gerrit-Reviewer: Alex Behm