Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 23061200C8E for ; Thu, 8 Jun 2017 20:54:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 16E58160BD5; Thu, 8 Jun 2017 18:54:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D3B9160BC3 for ; Thu, 8 Jun 2017 20:54:07 +0200 (CEST) Received: (qmail 83014 invoked by uid 500); 8 Jun 2017 18:54:06 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 83003 invoked by uid 99); 8 Jun 2017 18:54:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jun 2017 18:54:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 014FBCA74C for ; Thu, 8 Jun 2017 18:54:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id b4mAmvLhEJKu for ; Thu, 8 Jun 2017 18:54:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7A12F5FD9C for ; Thu, 8 Jun 2017 18:54:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v58IrwWM015645; Thu, 8 Jun 2017 18:53:58 GMT Message-Id: <201706081853.v58IrwWM015645@ip-10-146-233-104.ec2.internal> Date: Thu, 8 Jun 2017 18:53:58 +0000 From: "Henry Robinson (Code Review)" To: Steve Carlin , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4892=3A_Session_ID_included_in_error_message=0A?= X-Gerrit-Change-Id: I721951aaf2425da62e61d65150e462a83716b02e X-Gerrit-ChangeURL: X-Gerrit-Commit: 4bd35389d13c3be465c363eb1e2fb3d0e787137c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 08 Jun 2017 18:54:08 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Looks good - please fix the long line, then I'll commit. Thanks! http://gerrit.cloudera.org:8080/#/c/7054/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 435: return_val, Status(Substitute("Invalid session id: $0", PrintId(session_id))), SQLSTATE_GENERAL_ERROR); Nit: can you fix the long line? For readability, maybe split into two lines, one that creates the string, one that returns the status. -- To view, visit http://gerrit.cloudera.org:8080/7054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721951aaf2425da62e61d65150e462a83716b02e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Steve Carlin Gerrit-HasComments: Yes